cmd: add CLI flags for proxy shutdown lifecycle management #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorris
force-pushed
the
proxy-lcm/shutdown
branch
2 times, most recently
from
7762e0c
to
80656fa
Compare
|
@mikemorris , thanks for making the PR. I am new to the world of consul-dataplane. Out of curiosity, do we have similar proxy shutdown feature in consul core ( |
Nope, this has been a longstanding feature/fix request that we're looking to address now, added relevant issue references to original post for context. The eventual implementation of graceful shutdown functionality in consul-dataplane, which these flags are intended to configure, will be managed by Helm configuration for both regular pods and jobs and triggered by a preStop hook in consul-k8s for jobs. |
mikemorris
force-pushed
the
proxy-lcm/shutdown
branch
2 times, most recently
from
5be431b
to
1ffb8ac
Compare
…gs for proxy sidecar lifecycle management
and -shutdown-grace-periods flags
mikemorris
force-pushed
the
proxy-lcm/shutdown
branch
from
1ffb8ac
to
04e73f2
Compare
1 task
mikemorris
force-pushed
the
proxy-lcm/shutdown
branch
from
e2caa1d
to
bd4d480
Compare
mikemorris
force-pushed
the
proxy-lcm/shutdown
branch
from
8ab0448
to
c687111
Compare
pglass
approved these changes
Jun 6, 2023
DanStough
added a commit
that referenced
this pull request
Jun 14, 2023
)" This reverts commit 3d37b9f.
DanStough
added a commit
that referenced
this pull request
Jun 14, 2023
* Revert "proxy-lifecycle: catch SIGTERM and initiate graceful shutdown (#130)" This reverts commit 40c99dc. * Revert "proxy-lifecycle: add HTTP Server with endpoints for proxy lifecycle shutdown (#115)" This reverts commit 0047e65. * Revert "cmd: add CLI flags for proxy shutdown lifecycle management (#100)" This reverts commit 3d37b9f.
This was referenced Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs hashicorp/consul-k8s#536, hashicorp/consul-k8s#650
Adds the following CLI flags for proxy shutdown lifecycle management, disabled by default:
-shutdown-drain-listeners-shutdown-grace-periodAdds the following CLI flags for managing where the proxy lifecycle HTTP APIs are exposed:
-graceful-shutdown-path-graceful-portNotes for reviewers
pkg/consuldp/consul_dataplane_test.gohas tests exclusively for required configuration, should optional flags like those being added in this PR be tested somewhere else?envoy/proxy_test.golooks like a reasonable places to check the actual graceful shutdown behavior once implemented (and if enabled), but too broad a scope for just checking the flags set configuration properly.Should this wait to merge until the underlying functionality for these flags is implemented?-shutdown-delayCLI flag, do we care about the naming discrepancy? The implemented functionality may differ slightly because of how we'll be handling connection draining...