Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix CI skip script hole #618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: fix CI skip script hole #618

wants to merge 1 commit into from

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Sep 16, 2024 •
edited
Loading

In some environments, the script will not fail despite SKIP_CHECK_BRANCH being unset, leading to the script explicitly skipping CI when it should fail fast.

Prevent this by explicitly checking for the env var.

This change is a port of hashicorp/consul#21741.

Testing

❯ ./.github/scripts/check_skip_ci.sh
./.github/scripts/check_skip_ci.sh: line 16: SKIP_CHECK_BRANCH: SKIP_CHECK_BRANCH is required

@zalimeni zalimeni added backport/1.1 Changes are backported to 1.1 backport/1.3 Changes are backported to 1.3 backport/1.4 Changes are backported to 1.4 backport/1.5 Changes are backported to 1.5 labels Sep 16, 2024
@zalimeni zalimeni requested a review from a team as a code owner September 16, 2024 21:28
@zalimeni zalimeni added the pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog label Sep 16, 2024
@zalimeni zalimeni force-pushed the zalimeni/fix-scan-ci-skip-config branch from 6e6c855 to ebe11c2 Compare September 17, 2024 15:57
@zalimeni zalimeni enabled auto-merge (squash) September 17, 2024 15:58
@zalimeni
ci: fix CI skip script hole
43f13f5 
In some environments, the script will not fail despite SKIP_CHECK_BRANCH
being unset, leading to the script explicitly skipping CI when it should
fail fast.

Prevent this by explicitly checking for the env var.

This change is a port of hashicorp/consul#21741.
@zalimeni zalimeni force-pushed the zalimeni/fix-scan-ci-skip-config branch from ebe11c2 to 43f13f5 Compare September 17, 2024 17:59
@sarahalsmiller sarahalsmiller added the backport/1.6 Changes are backported to 1.6 label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduzgun-security dduzgun-security Awaiting requested review from dduzgun-security

@jm96441n jm96441n Awaiting requested review from jm96441n

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport/1.1 Changes are backported to 1.1 backport/1.3 Changes are backported to 1.3 backport/1.4 Changes are backported to 1.4 backport/1.5 Changes are backported to 1.5 backport/1.6 Changes are backported to 1.6 pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zalimeni @jm96441n @sarahalsmiller