Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Some providers do not support ingress pathType: Prefix #1012

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

TJM
Copy link
Contributor

@TJM TJM commented Jun 28, 2021

Changes proposed in this PR:

  • Make PathType a parameter so it can be overridden (for example on the latest GKE 1.19.10)

How I've tested this PR:
helm template with a test.yaml that enables ingress and has a test host
Also tried the "bats" test? (make)

How I expect reviewers to test this PR:
see above?

If you want to test overriding the value, it would be like

helm install consul . -f test.yaml

test.yaml:

ui:
  ingress:
    enabled: true
    pathType: ImplementationSpecific
    hosts:
      - host: foo.bar
        paths:
          - /

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

Fixes: #1011

@TJM TJM force-pushed the fix/ingress-path-type branch 2 times, most recently from ecad008 to 29ebfe8 Compare June 28, 2021 23:52
@TJM
Copy link
Contributor Author

TJM commented Jun 28, 2021

circleci@c587be94a60b:/test$ bats test/unit/ui-ingress.bats
 ✓ ui/Ingress: disabled by default
 ✓ ui/Ingress: enable with ui.ingress.enabled
 ✓ ui/Ingress: disable with ui.ingress.enabled
 ✓ ui/Ingress: disable with ui.ingress.enabled dash string
 ✓ ui/Ingress: no hosts by default
 ✓ ui/Ingress: hosts can be set
 ✓ ui/Ingress: exposes single port 80 when global.tls.enabled=false
 ✓ ui/Ingress: exposes single port 443 when global.tls.enabled=true and global.tls.httpsOnly=true
 ✓ ui/Ingress: exposes the port 80 when global.tls.enabled=true and global.tls.httpsOnly=false
 ✓ ui/Ingress: exposes the port 443 when global.tls.enabled=true and global.tls.httpsOnly=false
 ✓ ui/Ingress: no tls by default
 ✓ ui/Ingress: tls can be set
 ✓ ui/Ingress: tls with secret name can be set
 ✓ ui/Ingress: no annotations by default
 ✓ ui/Ingress: annotations can be set
 ✓ ui/Ingress: default PathType Prefix
 ✓ ui/Ingress: set PathType ImplementationSpecific

17 tests, 0 failures

PS: Thanks for the Docker image :)

@TJM
Copy link
Contributor Author

TJM commented Jun 29, 2021

I have to assume that the acceptance tests that failed are because I ran them, and don't have access to a protected enterprise license variable?

Looks like #1016 will fix this once it is merged :)

@TJM TJM changed the title Some providers do not support PathType: Prefix Some providers do not support ingress pathType: Prefix Jun 30, 2021
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution @TJM

@thisisnotashwin
Copy link
Contributor

Closes #1011

@thisisnotashwin thisisnotashwin merged commit fcc97e1 into hashicorp:master Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE Ingress requires pathType to be ImplementationSpecific
2 participants