-
Notifications
You must be signed in to change notification settings - Fork 386
Add ability to manual specify a server-cert #1046
Add ability to manual specify a server-cert #1046
Conversation
…secret containing server-cert
Hi @barrymars out of curiosity are you potentially using Vault for minting your server certs? How do you envision rotating them? We are looking into further integrations with Vault to support retrieving server certs from Vault for TLS. |
we're actually moving away from vault in favour of AWS secrets manager. hadn't got as far as working out certificate rotation, still at the proof of concept stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for making this change!
With server cert provided, I think we also need to disable tls-init and tls-init-cleanup jobs.
…k that caCert is set if serverCert is
good call @ishustava I am using the helm chart via Tanka (which doesn't support hooks), so hadn't thought of that I've also added a sanity check so that if setting serverCert you have to have caCert set too |
Co-authored-by: Iryna Shustava <[email protected]>
Co-authored-by: Iryna Shustava <[email protected]>
…erverCert specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks so much for this contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and @sadjamz!
Changes proposed in this PR:
-This coupled with the autoEncrypt feature, removes the need for the tls-init job and so can be run in a gitops way without having to rely on helm hooks etc.
How I've tested this PR:
Used to deploy consul into both local 'kind' cluster and AWS EKS cluster.
Checklist: