Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Kyle Schochenmaier <[email protected]>
  • Loading branch information
jmurret and kschoche committed May 20, 2022
1 parent 32f54f5 commit 892231f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions acceptance/framework/vault/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,12 @@ func (config *SaveVaultSecretConfiguration) Save(t *testing.T, vaultClient *vapi
path "%s" {
capabilities = ["read"]
}`, config.Path)
// Create the Vault Policy for the gossip key.
// Create a Vault Policy for the secret with read capabilities.
logger.Log(t, "Creating policy")
err := vaultClient.Sys().PutPolicy(config.PolicyName, policy)
require.NoError(t, err)

// Create the gossip secret.
// Create the KV2 secret.
logger.Logf(t, "Creating the %s secret", config.Path)
params := map[string]interface{}{
"data": map[string]interface{}{
Expand All @@ -182,7 +182,7 @@ func (config *SaveVaultSecretConfiguration) Save(t *testing.T, vaultClient *vapi
require.NoError(t, err)
}

// CreateConnectCAPolicyForDatacenter creates the Vault Policy for the connect-ca in a given datacenter.
// CreateConnectCARootAndIntermediatePKIPolicy creates the Vault Policy for the connect-ca in a given datacenter.
func CreateConnectCARootAndIntermediatePKIPolicy(t *testing.T, vaultClient *vapi.Client, policyName, rootPath, intermediatePath string) {
// connectCAPolicy allows Consul to bootstrap all certificates for the service mesh in Vault.
// Adapted from https://www.consul.io/docs/connect/ca/vault#consul-managed-pki-paths.
Expand Down

0 comments on commit 892231f

Please sign in to comment.