Skip to content

Commit

Permalink
Fix test flakes. (#2483)
Browse files Browse the repository at this point in the history
  • Loading branch information
wilkermichael committed Jul 11, 2023
1 parent 2906300 commit c7bbbef
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions acceptance/framework/connhelper/connect_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func (c *ConnectHelper) DeployClientAndServer(t *testing.T) {
// deployments because golang will execute them in reverse order
// (i.e. the last registered cleanup function will be executed first).
t.Cleanup(func() {
retrier := &retry.Timer{Timeout: 30 * time.Second, Wait: 100 * time.Millisecond}
retrier := &retry.Timer{Timeout: 60 * time.Second, Wait: 100 * time.Millisecond}
retry.RunWith(retrier, t, func(r *retry.R) {
tokens, _, err := c.ConsulClient.ACL().TokenList(nil)
require.NoError(r, err)
Expand Down Expand Up @@ -132,19 +132,6 @@ func (c *ConnectHelper) DeployClientAndServer(t *testing.T) {
})
}

// CreateResolverRedirect creates a resolver that redirects to a static-server, a corresponding k8s service,
// and intentions. This helper is primarly used to ensure that the virtual-ips are persisted to consul properly.
func (c *ConnectHelper) CreateResolverRedirect(t *testing.T) {
logger.Log(t, "creating resolver redirect")
options := c.Ctx.KubectlOptions(t)
kustomizeDir := "../fixtures/cases/resolver-redirect-virtualip"
k8s.KubectlApplyK(t, options, kustomizeDir)

helpers.Cleanup(t, c.Cfg.NoCleanupOnFailure, func() {
k8s.KubectlDeleteK(t, options, kustomizeDir)
})
}

// TestConnectionFailureWithoutIntention ensures the connection to the static
// server fails when no intentions are configured.
func (c *ConnectHelper) TestConnectionFailureWithoutIntention(t *testing.T) {
Expand Down

0 comments on commit c7bbbef

Please sign in to comment.