[NET-10547] openshift: re-order SCC volume list for Argo sync #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
added
backport/1.1.x
zalimeni
force-pushed
the
zalimeni/net-10547-openshift-scc-volume-order
branch
from
18ed9ce
to
3f0f19b
Compare
Due to logic in OpenShift's admissions hook that force-reorders explicit and implicit entries in this list, our `SecurityContextConstraints` entries will never successfully sync via tools like ArgoCD, which expect an exact input and output match when diff'ing. More details on the problem addressed by this change and potential future improvements to avoid it in the future can be found in #4208 (see comments).
zalimeni
force-pushed
the
zalimeni/net-10547-openshift-scc-volume-order
branch
from
3f0f19b
to
cd0cd19
Compare
This was referenced Aug 5, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to logic in OpenShift's admissions hook that force-reorders explicit and implicit entries in this list, our
SecurityContextConstraintsentries will never successfully sync via tools like ArgoCD, which expect an exact input and output match when diff'ing.More details on the problem addressed by this change and potential future improvements to avoid it in the future can be found in #4208 (see comments).
Changes proposed in this PR
volumesentries to match the post-reconciliation order persisted by OpenShiftHow I've tested this PR
consul-cniSCC.How I expect reviewers to test this PR
👀
Checklist