Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [NET-10547] openshift: re-order SCC volume list for Argo sync into release/1.5.x #4236

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #4227 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

The below text is copied from the body of the original PR.


Due to logic in OpenShift's admissions hook that force-reorders explicit and implicit entries in this list, our SecurityContextConstraints entries will never successfully sync via tools like ArgoCD, which expect an exact input and output match when diff'ing.

More details on the problem addressed by this change and potential future improvements to avoid it in the future can be found in #4208 (see comments).

Changes proposed in this PR

  • Reorder SCC volumes entries to match the post-reconciliation order persisted by OpenShift

How I've tested this PR

  • Spun up a local OpenShift CRC cluster w/ ArgoCD (GitOps Operator), deployed original and modified charts to verify fix results in a fully synced consul-cni SCC.
  • Tested on Azure using community ArgoCD operator, same results.

How I expect reviewers to test this PR

👀

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core merged commit b2227f6 into release/1.5.x Aug 5, 2024
49 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/zalimeni/net-10547-openshift-scc-volume-order/sincerely-stunning-tarpon branch August 5, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants