Initial support for wan fed using Vault as secrets backend #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
force-pushed
the
ishustava/vault-wan-fed
branch
6 times, most recently
from
bf10149
to
1c03ab2
Compare
ishustava
requested review from
a team,
jmurret and
kschoche
and removed request for
a team
ishustava
force-pushed
the
ishustava/vault-wan-fed
branch
from
1c03ab2
to
b342d8c
Compare
kschoche
reviewed
Feb 9, 2022
kschoche
reviewed
Feb 9, 2022
kschoche
reviewed
Feb 9, 2022
| "policies": fmt.Sprintf("consul-gossip,connect-ca,consul-server-%s", datacenter), | ||
| "ttl": "24h", | ||
| } | ||
| _, err = vaultClient.Logical().Write(fmt.Sprintf("auth/%s/role/consul-server", authPath), params) |
There was a problem hiding this comment.
No changes needed but I am thinking ahead to the documentation and wondering what you think about us suggesting that the server roles also have DC appended to help the user visually? Thoughts?
There was a problem hiding this comment.
🤔 we could do that
kschoche
reviewed
Feb 9, 2022
kschoche
approved these changes
Feb 9, 2022
ishustava
force-pushed
the
ishustava/vault-wan-fed
branch
from
b342d8c
to
64cb04f
Compare
thisisnotashwin
approved these changes
Feb 9, 2022
Comment on lines
+20
to
+21
| // connectCAPolicy allows Consul to bootstrap all certificates for the service mesh in Vault. | ||
| // Adapted from https://www.consul.io/docs/connect/ca/vault#consul-managed-pki-paths. |
ishustava
force-pushed
the
ishustava/vault-wan-fed
branch
from
64cb04f
to
d1c08cd
Compare
geobeau
pushed a commit
to geobeau/consul-k8s
that referenced
this pull request
May 20, 2022
Fork PRs don't have access to the enterprise license secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This is initial support for the Consul WAN federation which includes only gossip and TLS credentials. Other credentials will be added in a separate PR.
How I've tested this PR:
acceptance tests
How I expect reviewers to test this PR:
👀
Checklist:
CHANGELOG entry added(will be added as one entry in the last PR in the wan federation with vault series)