-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api-gateway: add node:read policy #1018
Conversation
To avoid silently filtering all nodes when ACLs are enabled and returning an empty set when attempting to map routes to Consul services registered in consul-k8s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the api gateway side of things, this LGTM, not sure if we want other k8s folks to sign off first though, also will need a Changelog entry.
@@ -154,6 +154,9 @@ namespace_prefix "" { | |||
policy = "write" | |||
intentions = "write" | |||
} | |||
node_prefix "" { | |||
policy = "read" | |||
} | |||
{{- if .EnableNamespaces }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for posterity sake, this enables this particular api call. Without the ACL, the call returns an empty node set and the controller is unable to resolve any Consul services needed in an HTTPRoute configuration.
I've requested review from @hashicorp/consul-eco-platform since that's who I was pointed to yesterday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To avoid silently filtering all nodes when ACLs are enabled and returning an empty set when attempting to map routes to Consul services registered in consul-k8s
Changes proposed in this PR:
node_prefix "" { policy = "read" }
to the API Gateway template forserver-acl-init
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: