Get federation secret from any of the places it is set. #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
requested review from
a team,
curtbushko and
ndhanushkodi
and removed request for
a team
curtbushko
reviewed
Apr 8, 2022
ishustava
reviewed
Apr 8, 2022
t-eckert
force-pushed
the
cli/fix-finding-fed-secret
branch
from
296e521
to
596d0d9
Compare
curtbushko
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
Added unit tests, ran the install tests which exercise the presence of the fed secret.
How I expect reviewers to test this PR:
Running the unit tests as well if you like.
Checklist: