Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update client-daemonset to not include ca-cert volumeMount with tls disabled #1194

Merged
merged 6 commits into from
Apr 29, 2022
Merged

update client-daemonset to not include ca-cert volumeMount with tls disabled #1194

merged 6 commits into from
Apr 29, 2022

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented Apr 28, 2022 •
edited
Loading

We were mistakenly adding the consul-ca-cert volumeMount to the acl-init container when tls was disabled.
Fixes #1185

Changes proposed in this PR:

  • Do not add the consul-ca-cert volumeMount to the client-acl-init init container when global.tls.enabled=false
  • Fix the existing unit test.

How I've tested this PR:
unit test

How I expect reviewers to test this PR:
👀 🧪

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@kschoche kschoche added type/bug Something isn't working area/chart-only Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field labels Apr 28, 2022
@kschoche kschoche requested a review from a team April 28, 2022 18:09
@kschoche kschoche self-assigned this Apr 28, 2022
@kschoche kschoche requested review from curtbushko and t-eckert and removed request for a team April 28, 2022 18:09
@kschoche kschoche marked this pull request as ready for review April 28, 2022 18:33
curtbushko
curtbushko reviewed Apr 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kschoche @curtbushko
Update CHANGELOG.md
660caeb 
Co-authored-by: Curt Bushko <[email protected]>
curtbushko
curtbushko approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

t-eckert
t-eckert reviewed Apr 29, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
t-eckert
t-eckert approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kschoche
Update CHANGELOG.md
914d0f9 
Co-authored-by: Thomas Eckert <[email protected]>
@kschoche kschoche merged commit 54c641b into main Apr 29, 2022
@kschoche kschoche deleted the fix_client_daemonset_ca_cert branch April 29, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-eckert t-eckert t-eckert approved these changes

@curtbushko curtbushko curtbushko approved these changes

@thisisnotashwin thisisnotashwin Awaiting requested review from thisisnotashwin

Assignees

@kschoche kschoche

Labels
area/chart-only Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid daemonset definition when tls is not enabled
4 participants
@kschoche @curtbushko @thisisnotashwin @t-eckert