Correct webhook-cert-manager-clusterrole to utilize the web-cert-manager podsecuritypolicy rather than connect-injectors when global.EnablePodSecurityPolicies is true. #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
reviewed
May 3, 2022
| resourceNames: | ||
| - {{ template "consul.fullname" . }}-webhook-cert-manager | ||
| verbs: | ||
| - use |
There was a problem hiding this comment.
I think the part below is a bug. It should be using the cert-manager policy.
| resourceNames: | ||
| - {{ template "consul.fullname" . }}-webhook-cert-manager | ||
| verbs: | ||
| - use | ||
| - apiGroups: | ||
| - policy |
There was a problem hiding this comment.
You can just rename the connect-injector to be the webhook-cert-manager. It being connect-injector is a bug!
jmurret
changed the title
2 tasks
lkysow
approved these changes
May 3, 2022
thisisnotashwin
approved these changes
May 3, 2022
|
We can still remove the controller from the sync test as the test does not actually require a controller to run! |
|
👍 I'll merge that other PR tomorrow after we confirm the nightly tests are all set. |
Co-authored-by: Luke Kysow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: