-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configurable envoy proxy concurrency #1277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only had some minor questions/nits but I think it all comes down to naming.
I prefer sidecar instead of envoy for consistency reasons. I think it is concurrency that is the word that makes it confusing as I immediately thought of replicas when I read the summary.
Would thread-concurrency make it clearer? -default-sidecar-proxy-thread-concurrency?
Naming is hard. 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE
04825a5
to
c49dd14
Compare
Changes proposed in this PR:
consul.hashicorp.com/consul-envoy-proxy-concurrency
which will override the default for any given pod.Notes to reviewers:
2
was chosen via a brief discussion with @blake and @david-yu but I'm open to suggestions if we have more information. Additional reading on this can be had at https://blog.envoyproxy.io/envoy-threading-model-a8d44b922310 where they encourage setting the value very low for sidecars and high for edge proxies.envoy
into the name is a break from our typical conventions, but alsosidecar
in this context is muddy (consul-sidecar vs envoy proxy sidecar) and I wanted it to be clear that it was an envoy specific flag.--concurrency 42
to theirconnectInject.sidecarProxy.extraArgs
because I thought it was a bit messy to have to edit strings in deployments vs just adding a new annotation to your deployment or set a default via helm.How I've tested this PR:
unit tests + acceptance tests
How I expect reviewers to test this PR:
👀
Checklist: