Enable CRD controller to talk to Consul servers #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
requested review from
a team,
jmurret and
thisisnotashwin
and removed request for
a team
thisisnotashwin
approved these changes
Jul 7, 2022
jmurret
approved these changes
Jul 7, 2022
| @@ -364,6 +364,18 @@ spec: | |||
| {{- if .Values.global.adminPartitions.enabled }} | |||
| -partition={{ .Values.global.adminPartitions.name }} \ | |||
| {{- end }} | |||
| {{- if .Values.externalServers.enabled }} | |||
| {{- if .Values.global.tls.enabled }} | |||
There was a problem hiding this comment.
[non-blocking] would would you think about putting this in a template since it seems to be repeated quite a bit?
There was a problem hiding this comment.
yeah great question! I think I'll actually be able to get rid of this init container from all components altogether once agentless is done. My plan is to move login/logout logic into controllers to do at startup and shutdown. Other components that currently use this will switch to consul-dataplane instead doing the login for them.
thisisnotashwin
pushed a commit
that referenced
this pull request
Sep 19, 2022
thisisnotashwin
pushed a commit
that referenced
this pull request
Sep 19, 2022
thisisnotashwin
pushed a commit
that referenced
this pull request
Sep 19, 2022
ishustava
added a commit
that referenced
this pull request
Sep 20, 2022
t-eckert
pushed a commit
that referenced
this pull request
Sep 20, 2022
thisisnotashwin
pushed a commit
that referenced
this pull request
Sep 20, 2022
ishustava
added a commit
that referenced
this pull request
Sep 20, 2022
t-eckert
pushed a commit
that referenced
this pull request
Sep 21, 2022
thisisnotashwin
pushed a commit
that referenced
this pull request
Sep 22, 2022
thisisnotashwin
pushed a commit
that referenced
this pull request
Sep 27, 2022
jmurret
pushed a commit
that referenced
this pull request
Sep 27, 2022
t-eckert
pushed a commit
that referenced
this pull request
Sep 28, 2022
t-eckert
pushed a commit
that referenced
this pull request
Sep 28, 2022
t-eckert
pushed a commit
that referenced
this pull request
Sep 28, 2022
ishustava
added a commit
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
acceptance tests
How I expect reviewers to test this PR:
👀
Checklist: