Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the API Gateway controller to create and update Secrets #1542

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Allow the API Gateway controller to create and update Secrets #1542

merged 3 commits into from
Sep 28, 2022

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Sep 27, 2022 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:
Deployed Consul API Gateway using this branch and hashicorp/consul-api-gateway#391

How I expect reviewers to test this PR:
See above

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@nathancoleman nathancoleman marked this pull request as ready for review September 27, 2022 18:40
@nathancoleman nathancoleman requested review from a team, ishustava and wilkermichael and removed request for a team September 27, 2022 18:41
nathancoleman
nathancoleman commented Sep 27, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nathancoleman nathancoleman added area/chart-only Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field theme/api-gateway Related to Consul API Gateway backport/0.49.x labels Sep 27, 2022
wilkermichael
wilkermichael approved these changes Sep 27, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nathancoleman nathancoleman merged commit 1d0d40a into main Sep 28, 2022
@nathancoleman nathancoleman deleted the apigw-create-update-secrets branch September 28, 2022 00:36
Merged
2 tasks
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkermichael wilkermichael wilkermichael approved these changes

@ishustava ishustava ishustava approved these changes

Assignees
No one assigned
Labels
area/chart-only Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field theme/api-gateway Related to Consul API Gateway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathancoleman @ishustava @wilkermichael