Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on curl since it is a source of numerous CVEs #1624

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Remove dependency on curl since it is a source of numerous CVEs #1624

merged 1 commit into from
Oct 18, 2022

Conversation

analogue
Copy link
Contributor

@analogue analogue commented Oct 17, 2022 •
edited by curtbushko
Loading

Context: NET-186

Changes proposed in this PR:

  • Remove the unused curl executable from the consul-k8s docker images

How I've tested this PR:

  • unit / acceptance tests are green

How I expect reviewers to test this PR:
👀

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@david-yu
Copy link
Contributor

It looks like everything works just fine with Curl removed?

@analogue
Copy link
Contributor Author

analogue commented Oct 17, 2022 •
edited
Loading

Yes, looks that way :) Let me clean up the PR and I'll mark as ready for review.

@analogue analogue changed the title test curl removal Remove dependency on curl since it is a source of numerous CVEs Oct 18, 2022
@analogue analogue changed the title Remove dependency on curl since it is a source of numerous CVEs Remove dependency on curl since it is a source of numerous CVEs Oct 18, 2022
@analogue analogue marked this pull request as ready for review October 18, 2022 15:49
@analogue analogue added the area/security Related to general security label Oct 18, 2022
@jmurret jmurret requested review from a team, curtbushko and wilkermichael and removed request for a team October 18, 2022 16:09
jmurret
jmurret approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thank you!

curtbushko
curtbushko approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@analogue analogue merged commit 1951a35 into main Oct 18, 2022
@analogue analogue deleted the sp/remove-curl branch October 18, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@jmurret jmurret jmurret approved these changes

@wilkermichael wilkermichael Awaiting requested review from wilkermichael

Assignees
No one assigned
Labels
area/security Related to general security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@analogue @hashicorp-cla @david-yu @curtbushko @jmurret