Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update demo charts and CLI command to not presume tproxy #1657

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Update demo charts and CLI command to not presume tproxy #1657

merged 1 commit into from
Oct 28, 2022

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Oct 28, 2022

Changes proposed in this PR:

  • Update demo charts and CLI command to not presume tproxy
  • Also use the most recent version of hashicups

How I've tested this PR:

  • unit tests
  • manually using CLI to install hashicups and an HCP self-managed cluster all at once

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@jmurret jmurret marked this pull request as ready for review October 28, 2022 01:14
@ishustava ishustava merged commit b1580e8 into pre-release-1.0.0-beta4 Oct 28, 2022
@ishustava ishustava deleted the jm/fix-demo-no-tproxy branch October 28, 2022 15:19
jmurret added a commit that referenced this pull request Oct 31, 2022
@jmurret
Update demo charts and CLI command to not presume tproxy (#1657)
f5104b8
jmurret added a commit that referenced this pull request Nov 9, 2022
@jmurret
Modify implementation of -demo flag to use most recent hashicups an…
78b24f0 
…d not presume transparent proxy (#1663)

* Update demo charts and CLI command to not presume tproxy (#1657)

* add missing hashicups files (#1661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi

@wilkermichael wilkermichael Awaiting requested review from wilkermichael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmurret @ishustava