Update Helm Chart for running API Gateways in Agentless config and with external servers #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @t-eckert just heads up, but just for some clarity I think we probably want the following for full compatibility. Checked are the ones that I think are the highest priority. Agent-based
Agentless
The agentless/external setup will not work with our 0.4 release. |
t-eckert
force-pushed
the
te/gateway-agentless
branch
2 times, most recently
from
f8e1898
to
b5730b3
Compare
t-eckert
force-pushed
the
te/gateway-agentless
branch
from
d4c0da2
to
66b9de1
Compare
t-eckert
requested review from
andrewstucki,
a team,
ndhanushkodi and
ishustava
and removed request for
a team
andrewstucki
approved these changes
Nov 11, 2022
andrewstucki
suggested changes
Nov 11, 2022
mikemorris
approved these changes
Nov 12, 2022
andrewstucki
approved these changes
Nov 14, 2022
Co-authored-by: Andrew Stucki <[email protected]>
Co-authored-by: Mike Morris <[email protected]>
Co-authored-by: Mike Morris <[email protected]>
Co-authored-by: Mike Morris <[email protected]>
t-eckert
force-pushed
the
te/gateway-agentless
branch
from
02de95a
to
d914e2a
Compare
thisisnotashwin
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
externalServers.httpPort.CONSUL_HTTP_ADDRto the first external server host whenexternalServersis enabled.CONSUL_HTTP_ADDRusing Kube DNS when running with local servers.http(s)://and instead set this using theCONSUL_HTTP_SSLenvironment variable.CONSUL_TLS_SERVER_NAMEto support SNI with external servers.consul.addressfor the GatewayClassConfig whether using external or local servers.How I've tested this PR:
0.4.0with Consul-k8s1.0.0-beta5(Agentful) and local servers0.5.0with Consul-k8s1.0.0-beta5(Agentful) and local servers0.4.0with Consul-k8s1.0.0-beta5(Agentless) and local servers0.5.0with Consul-k8s1.0.0-beta5(Agentless) and local servers0.4.0with Consul-k8s1.0.0-beta5(Agentful) and external servers0.5.0with Consul-k8s1.0.0-beta5(Agentful) and external servers0.5.0with Consul-k8s1.0.0-beta5(Agentless) and external serversAlso verified that "Deployed API Gateways
0.4.0with Consul-k8s1.0.0-beta5(Agentless) and external servers" does not work as is expected.How I expect reviewers to test this PR:
Checklist: