Add envoyExtensions field to serviceDefaults and proxyDefaults CRDs #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkermichael
force-pushed
the
mw/update-crd-envoy-extensions
branch
9 times, most recently
from
27254aa
to
0df18ab
Compare
wilkermichael
changed the title
wilkermichael
commented
Jan 10, 2023
wilkermichael
commented
Jan 10, 2023
| "meshgateway.mode": { | ||
| &ProxyDefaults{ | ||
| input: &ProxyDefaults{ |
There was a problem hiding this comment.
You can ignore most of these, I just autogenerated the field names rather than leaving them blank
thisisnotashwin
approved these changes
Jan 11, 2023
| @@ -239,7 +244,7 @@ func (in *ProxyDefaults) validateConfig(path *field.Path) *field.Error { | |||
| } | |||
| var outConfig map[string]interface{} | |||
| if err := json.Unmarshal(in.Spec.Config, &outConfig); err != nil { | |||
| return field.Invalid(path, in.Spec.Config, fmt.Sprintf(`must be valid map value: %s`, err)) | |||
| return field.Invalid(path, string(in.Spec.Config), fmt.Sprintf(`must be valid map value: %s`, err)) | |||
wilkermichael
force-pushed
the
mw/update-crd-envoy-extensions
branch
3 times, most recently
from
655f93d
to
19f0f6d
Compare
- Added fields to support EnvoyExtensions - Added missing BalanceInboundConnections field
- most of these changes are parallel to what was done in serviceDefaults - proxyDefaults makes use of the envoyExtension(s) definition in serviceDefaults and also makes use of the validation/toConsul logic defined there
- Added tests for proxyDefault - Added tests for serviceDefault EnvoyExtension test cases should be basically the same for both CRDs
wilkermichael
force-pushed
the
mw/update-crd-envoy-extensions
branch
from
19f0f6d
to
26fd456
Compare
david-yu
pushed a commit
that referenced
this pull request
Feb 14, 2023
…1823) * updated consul api to the latest * added new ServiceDefault fields to the serviceDefaults CRD - Added fields to support EnvoyExtensions - Added missing BalanceInboundConnections field * added EnvoyExtensions to proxyDefaults CRD - most of these changes are parallel to what was done in serviceDefaults - proxyDefaults makes use of the envoyExtension(s) definition in serviceDefaults and also makes use of the validation/toConsul logic defined there * added tests for new fields - Added tests for proxyDefault - Added tests for serviceDefault - EnvoyExtension test cases should be basically the same for both CRDs * generate the manifests and generate deepcopy * updated the changelog * added CI test to catch bad terraform formatting * formatted terraform files * update contributing doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE TO THE REVIEWER: I organize my commits so that they're meaningful, I suggest reviewing my code commit by commit. There are a lot of files changed, but some of these are generated/fixed terraform formatting.
Changes proposed in this PR:
This PR adds
envoyExtensionsto theserviceDefaultsandproxyDefaultsCRDs. The goal is to create parity with what is already in Consul:serviceDefaults
proxyDefaults
In addition to adding
envoyExtensionsI also added the following:BalanceInboundConnectionsfield toserviceDefaultsHow I've tested this PR:
proxyDefaultandserviceDefaultresources and verified the validation logic and that they synced correctly with ConsulproxyDefaultandserviceDefaultwith the new fieldsHow I expect reviewers to test this PR:
👀
Checklist: