-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When configured, use the health check of the proxy #1841
Conversation
- When a service is configured with the correct annotation, a readiness endpoint with be configured in Consul dataplane and the readiness probe of the sidecar will be configured to use that endpoint to determine the health of the system. Additionally, when t-proxy is enabled, that port shall be in the ExcludeList for inbound connections.
d74b401
to
f77b0e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few comments, but don't think they are blocking.
control-plane/connect-inject/webhook/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
- Improve changelog wording. - Make useProxyHealthCheck check for all truthy values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I thought I saw something with CNI but you had that covered and our cleanup in 1.0 had unified a bunch of things that makes is so much cleaner (specifically iptablesConfigJSON being used everywhere).
* When a service is configured with the correct annotation, a readiness endpoint with be configured in Consul dataplane and the readiness probe of the sidecar will be configured to use that endpoint to determine the health of the system. Additionally, when t-proxy is enabled, that port shall be in the ExcludeList for inbound connections.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: