DRAFT: Reset log levels per pod #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
reviewed
Jan 31, 2023
t-eckert
reviewed
Jan 31, 2023
t-eckert
reviewed
Jan 31, 2023
jm96441n
force-pushed
the
reset-all-loggers-in-pod-to-default
branch
from
c5d48da
to
759f50e
Compare
jm96441n
force-pushed
the
set-envoy-log-level-per-pod
branch
from
f3ba599
to
587f91c
Compare
jm96441n
force-pushed
the
reset-all-loggers-in-pod-to-default
branch
from
759f50e
to
87f9a38
Compare
t-eckert
reviewed
Feb 6, 2023
t-eckert
reviewed
Feb 6, 2023
CHANGELOG.md
Outdated
| @@ -26,6 +26,8 @@ IMPROVEMENTS: | |||
| * Control-Plane | |||
| * Add support for the annotation `consul.hashicorp.com/use-proxy-health-check`. When this annotation is used by a service, it configures a readiness endpoint on Consul Dataplane and queries it instead of the proxy's inbound port which forwards requests to the application. [[GH-1824](https://github.com/hashicorp/consul-k8s/pull/1824)], [[GH-1841](https://github.com/hashicorp/consul-k8s/pull/1841)] | |||
| * Add health check for synced services based on the status of the Kubernetes readiness probe on synced pod. [[GH-1821](https://github.com/hashicorp/consul-k8s/pull/1821)] | |||
| * CLI: | |||
| * Add `consul-k8s proxy log podname` command for displaying and mofidying Envoy log levels for a given Pod. [GH-1844](https://github.com/hashicorp/consul-k8s/pull/1844), [GH-1849](https://github.com/hashicorp/consul-k8s/pull/1849), [GH-1864](https://github.com/hashicorp/consul-k8s/pull/1864) | |||
There was a problem hiding this comment.
If these all merge into a single feature branch, I would just include the one feature branch that targets main instead of all 3. Just for tidiness.
There was a problem hiding this comment.
so each of these PR's is targeting main, right now this PR is targeting the set-envoy... branch because it's dependent on some of the work in there
There was a problem hiding this comment.
You have a spelling mistake 'mofidying' 😃
There was a problem hiding this comment.
nice catch! lemme fix that
jm96441n
force-pushed
the
set-envoy-log-level-per-pod
branch
from
33a884f
to
de88a41
Compare
jm96441n
force-pushed
the
reset-all-loggers-in-pod-to-default
branch
from
1c6d116
to
cfb3d58
Compare
jm96441n
force-pushed
the
reset-all-loggers-in-pod-to-default
branch
from
a4c81fc
to
5b14be4
Compare
Move format parsing into envoy package Move enovy to common package, move param parsing to calling package Added changelog for proxy log command Cleaning up usage message and error message from pr review clean up issue with exported constant used in test, fmt'd/linted export loggers undo autoformatting last fix to changelog to clean up from auto format set level on reset for envoy log level to info Fix spelling mistake in changelog
jm96441n
force-pushed
the
reset-all-loggers-in-pod-to-default
branch
from
5b14be4
to
3dc73a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
kind create clusterconsul-values.ymlfile in the above gist:consul-k8s install -config-file=consul-values.yaml -set global.image=hashicorp/consul:1.14.3server.yamlto your clusterkubectl apply server.yamlkubectl get podskubectl port-forward <POD_NAME> 19000:19000(where19000is the default admin port for the envoy proxy)consul-k8s proxy log <POD_NAME> -l warningand thenconsul-k8s proxy log <POD_NAME> -level grpc:error,kafka:critical,testing:off,admin:debugto set all loggers to warning, and then modify a few others to different levelsconsul-k8s proxy log <POD_NAME> -rto reset the levels and observe that all are set toinfoHow I expect reviewers to test this PR:
Checklist: