Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline Updates #1908

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Pipeline Updates #1908

merged 6 commits into from
Feb 17, 2023

Conversation

wilkermichael
Copy link
Contributor

@wilkermichael wilkermichael commented Feb 14, 2023 •
edited
Loading

If you go through my PR commit by commit it's easier to review, I typically add extra context and you won't see things change between commits unintentionally

Changes proposed in this PR:

  • Upgrade Go version to 1.20 and specifically 1.20.1 to address a CVE
  • Updated gotestsum calls to use testnames this improves debugging as you'll see which tests pass and fail, not just the package name with failing/passing tests
  • Added 1.1.x release branch for nightly testing

How I've tested this PR:
I verified that the nightly tests passed:
image

How I expect reviewers to test this PR:
👀

Checklist:

  • [N/A] Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@wilkermichael wilkermichael force-pushed the mw/fix-pipeline-feb-2023 branch 7 times, most recently from ff635be to d362d3f Compare February 15, 2023 23:23
@wilkermichael wilkermichael changed the title attempt 1 Pipeline Updates Feb 15, 2023
@wilkermichael wilkermichael added the backport/1.1.x Backport to release/1.1.x branch label Feb 17, 2023
@wilkermichael wilkermichael requested review from a team, thisisnotashwin and malizz and removed request for a team February 17, 2023 00:29
@wilkermichael wilkermichael marked this pull request as ready for review February 17, 2023 00:32
thisisnotashwin
thisisnotashwin approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Have a comment that is not related to the 1.20 change. Great work on this.

control-plane/subcommand/common/common_test.go Outdated Show resolved Hide resolved
@wilkermichael
updated to go 1.20
f53baa3 
- ran go mod tidy on all go mod files
@wilkermichael
updated go version to 1.20.1
da67f3d 
- removed compatibility tests, those won't be needed now that we have paired Consul/Consul-K8s versions
@wilkermichael
addressed linter error
47684b6 
- updated tests to remove require.New(t) and instead pass t directly when required
@wilkermichael
update to use gotestsum testname for better debugging
cfdbacf
@wilkermichael
add 1.1.x to the nightly release testing
ac26dfa
@wilkermichael wilkermichael merged commit 89494fd into main Feb 17, 2023
@wilkermichael wilkermichael deleted the mw/fix-pipeline-feb-2023 branch February 17, 2023 19:29
@thisisnotashwin thisisnotashwin mentioned this pull request Feb 17, 2023
Closed
1 task
This was referenced Feb 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@malizz malizz Awaiting requested review from malizz malizz was automatically assigned from hashicorp/consul-core-service-mesh

Assignees
No one assigned
Labels
backport/1.1.x Backport to release/1.1.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilkermichael @thisisnotashwin