Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [API Gateway] WAN Federation test and fixes into release/1.2.x #2322

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #2295 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:
This adds a WAN federation acceptance test for API Gateways. A few fixes went into it:

  1. We were disallowing ServiceResolver cross-DC redirects unless someone was explicitly in the default partition, but were only checking for "default" when an empty string means the same thing
  2. We needed to normalize the auth method name that we use for our deployments so that we use the DC-local one that we attach our binding rules to.
  3. Due to the way we watch and GC config entries, we needed to pass some additional metadata to ignore anything coming from a sync to a federated DC -- basically we were removing config entries if we didn't have the corresponding Kubernetes object backing them in our DC, when we shouldn't touch them because a corresponding Kubernetes object exists for them in another DC.

How I've tested this PR:
I tested this by running this locally on Kind with MetalLB installed so that the mesh gateways could find each other over WAN, but this doesn't typically work in a Kind setup, as the other acceptance test mentions, so it will be disabled for typical CI runs.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/net-4339/gateway-wan-fed/openly-champion-giraffe branch from c4afcf4 to 631f596 Compare June 9, 2023 13:53
@hc-github-team-consul-core hc-github-team-consul-core merged commit 88a954d into release/1.2.x Jun 9, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/net-4339/gateway-wan-fed/openly-champion-giraffe branch June 9, 2023 14:02
@t-eckert t-eckert mentioned this pull request Jun 15, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants