Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual backport of Improvement- Added helm inputs for managing audit logs into release/1.2.x #2370

Merged

Conversation

Ganeshrockz
Copy link
Contributor

Backport

This PR is manually created from #2265 to be assessed for backporting targeting the release/1.2.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Adds the relevant inputs in values.yaml to configure audit logging in Consul enterprise.
  • Behind the scenes, values get translated to the json configuration present here and the whole configuration is added as a file in the Consul server's config map.

How I've tested this PR:

  • Unit tests
  • CI

How I expect reviewers to test this PR:

  • I've added the auditLog field under server. Should the same be added to client?

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


@Ganeshrockz Ganeshrockz added the pr/no-backport signals that a PR will not contain a backport label label Jun 14, 2023
@david-yu
Copy link
Contributor

david-yu commented Jun 14, 2023

@Ganeshrockz We should merge this PR into 1.2.x after GA since code freeze happened yesterday.

@david-yu david-yu self-requested a review June 16, 2023 15:25
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe to merge now that tests are passing.

@Ganeshrockz Ganeshrockz merged commit ebcbcee into release/1.2.x Jun 16, 2023
@Ganeshrockz Ganeshrockz deleted the backport/net-189/add-helm-for-audit-logs-1.2.x branch June 16, 2023 15:36
@Ganeshrockz Ganeshrockz added the consul-india PRs/Issues assigned to Consul India team label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consul-india PRs/Issues assigned to Consul India team pr/no-backport signals that a PR will not contain a backport label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants