Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of first pass making gateway controllers less chatty into release/1.2.x #2550

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #2524 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

The gateway controllers are very chatty. This change allows for the log level in the helm chart to be utilized in the gateway controllers by setting the verbosity on the info statements we use.

I think it makes most sense to just put all of our info logging under a different level. I think the info logs are most useful as an all-or-nothing type of thing (besides a couple of exceptions, see below).
I think this because if a user really wanted to debug something with these logs, it would make sense to be able to see the whole lifecycle of the reconcile calls:


Reconciling
	Doing deployment
	Doing HTTPRoute
	etc.
Reconciling again

On their own they do not make a ton of sense. To turn on this log level, the user just changes global.logLevel to debug.

Exceptions to log-level:
When a user tries to delete a gatewayClass or a gatewayClassConfig, I left the info statements in saying that they cannot be deleted as they are still in use. These make sense to leave in, as they can happen outside of a general reconciliation loop.
gatewayClass controller
gatewayClassConfig controller

Room for improvement

Probably need to review the actual logging statements I added, make sure there is no copy-pasta errors

How I've tested this PR:

Ran the helm chart locally with log levels at debug/info, created resources to see the logging.

How I expect reviewers to test this PR:

Same as above


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core merged commit b6bb13c into release/1.2.x Jul 12, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/net-4412/shush-controller/specially-model-fowl branch July 12, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants