Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Consul client always logs into the local datacenter into release/1.0.x #2653

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #2652 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Update the CONSUL_LOGIN_DATACENTER logic for client daemonset to only login to the local datacenter as it uses a local authmethod and not a global authmethod.
  • This led to errors when attempting to deploy clients in a federated cluster.

How I've tested this PR:

  • @natemollica-nm was able to replicate the error and this fix fixed it in his federated cluster

How I expect reviewers to test this PR:

  • 👀

Checklist:


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core merged commit 0057640 into release/1.0.x Jul 25, 2023
4 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/ashwin/NET-1750-fix-bug-in-login-datacenter/early-current-titmouse branch July 25, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants