fail if service name != service account name #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
lkysow,
a team and
adilyse
and removed request for
a team
thisisnotashwin
force-pushed
the
verifyServiceAccountName
branch
from
56cd8eb
to
7e9d650
Compare
lkysow
reviewed
Jun 23, 2020
thisisnotashwin
force-pushed
the
verifyServiceAccountName
branch
from
7e9d650
to
a575978
Compare
thisisnotashwin
force-pushed
the
verifyServiceAccountName
branch
from
a575978
to
76b1028
Compare
adilyse
added
area/connect
ServiceAccountName in podSpec Signed-off-by: Ashwin Venkatesh <[email protected]>
thisisnotashwin
force-pushed
the
verifyServiceAccountName
branch
from
76b1028
to
6e434a5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check only occurs when ACLs are enable with connectInject.
Tested that it only performs this check when ACLs are enabled. Screenshot of error when incorrect pod config is applied
Closes #237
Signed-off-by: Ashwin Venkatesh [email protected]