Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1.x #2873

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1.x #2873

merged 1 commit into from
Aug 31, 2023

Conversation

absolutelightning
Copy link
Contributor

Changes proposed in this PR:

  • Add support for global.argocd.enabled flag in values.yaml which adds the
        "argocd.argoproj.io/hook": "Sync"
        "argocd.argoproj.io/hook-delete-policy": "HookSucceeded"

in the jobs -
server-acl-init-job

How I've tested this PR:

  • Bats Tests
    Manual Tests -
  • Created github pages to host helm charts following this medium article
  • Forked the repo and created a new branch - https://github.com/absolutelightning/consul-minikubes/tree/test-argocd.
  • Updated the repo with values from github helm charts created in step 1
  • Ran bash argocd.sh
  • kubectl port-forward svc/argocd-server -n argocd 8087:443
  • argocd admin initial-password -n argocd
  • Input username - admin and password output from previous step in UI at localhost:8087.
  • Recorded video
demoargocd.mov

Checklist:

@absolutelightning @Ganeshrockz @lkysow
Net 5229 create dedicated argocd stanza (#2785)
ea0c737 
* enable argocd

* adds bats test and setting argo annotations if global.argocd.enabled = true

* update comment

* added change log

* Update charts/consul/templates/gateway-cleanup-job.yaml

Co-authored-by: Ganesh S <[email protected]>

* comments fixes

* fix line diff

* change log fix

* fix comment

* Update .changelog/2785.txt

Co-authored-by: Luke Kysow <[email protected]>

---------

Co-authored-by: Ganesh S <[email protected]>
Co-authored-by: Luke Kysow <[email protected]>
@absolutelightning absolutelightning changed the title Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1x Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1.x Aug 31, 2023
@absolutelightning absolutelightning added the pr/no-backport signals that a PR will not contain a backport label label Aug 31, 2023
@absolutelightning absolutelightning enabled auto-merge (squash) August 31, 2023 06:29
@absolutelightning absolutelightning merged commit 21faa89 into release/1.1.x Aug 31, 2023
24 of 34 checks passed
@absolutelightning absolutelightning deleted the NET-5229-1.1.x branch August 31, 2023 06:42
@absolutelightning absolutelightning added the consul-india PRs/Issues assigned to Consul India team label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ganeshrockz Ganeshrockz Ganeshrockz approved these changes

Assignees
No one assigned
Labels
consul-india PRs/Issues assigned to Consul India team pr/no-backport signals that a PR will not contain a backport label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@absolutelightning @Ganeshrockz