Remove unnecessary dep on prometheus logging #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go mod tidy
kschoche
added
type/bug
kschoche
requested review from
a team,
lkysow and
thisisnotashwin
and removed request for
a team
lkysow
reviewed
Aug 19, 2020
| @@ -112,7 +111,7 @@ func (c *Command) Run(args []string) int { | |||
| case <-time.After(c.flagSyncPeriod): | |||
| continue | |||
| case <-c.sigCh: | |||
| log.Info("SIGINT received, shutting down") | |||
| logger.Info("SIGINT received, shutting down") | |||
lkysow
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This has an added effect of reducing the size of the consul-k8s binary by 1MB :-)
How I've tested this PR:
make clean && makeHow I expect reviewers to test this PR:
That it compiles.
Checklist:
^ Both unnecessary, just a cleanup