Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-6536 Adds stub of GatewayClass controller into v2 controllers #3245

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

missylbytes
Copy link
Contributor

Changes proposed in this PR:

  • Adds stub of GatewayClass controller into v2 controllers

How I've tested this PR:
👀
How I expect reviewers to test this PR:
👀

@missylbytes missylbytes added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Nov 21, 2023
@missylbytes missylbytes requested a review from a team November 21, 2023 18:45
Copy link
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathancoleman nathancoleman changed the title Adds stub of GatewayClass controller into v2 controllers NET-6536 Adds stub of GatewayClass controller into v2 controllers Nov 27, 2023
@nathancoleman nathancoleman enabled auto-merge (squash) November 27, 2023 23:28
@nathancoleman nathancoleman merged commit dc6a70a into main Nov 28, 2023
24 of 48 checks passed
@nathancoleman nathancoleman deleted the net-6536 branch November 28, 2023 00:01
jm96441n pushed a commit that referenced this pull request Nov 29, 2023
)

* Adds stub of GatewayClass controller into v2 controllers

* regen without weird spaces

* Update control-plane/config-entries/controllersv2/gateway_class_controller.go

---------

Co-authored-by: Nathan Coleman <[email protected]>
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
)

* Adds stub of GatewayClass controller into v2 controllers

* regen without weird spaces

* Update control-plane/config-entries/controllersv2/gateway_class_controller.go

---------

Co-authored-by: Nathan Coleman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry theme/mesh-gw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants