Net 6535- GatewayClassConfig controller stubs #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahalsmiller
added
pr/no-changelog
jm96441n
reviewed
Nov 27, 2023
| singular: gatewayclassconfig | ||
| scope: Cluster | ||
| versions: | ||
| - name: v1alpha1 |
There was a problem hiding this comment.
This is the V1 gatewayClassConfig. It won't be named external like we have for the Gateway and GatewayClass, so to avoid naming issues the file is being renamed here.
missylbytes
reviewed
Nov 28, 2023
| items: | ||
| type: string | ||
| type: array | ||
| type: object | ||
| deployment: | ||
| description: Deployment defines the deployment configuration for the |
There was a problem hiding this comment.
We expect the GatewayClassConfig to change pretty quickly (want to rework it to something more generic), so the missing descriptions are fine.
missylbytes
reviewed
Nov 28, 2023
| @@ -101,6 +101,7 @@ rules: | |||
| - meshgateways | |||
| - tcproutes | |||
| - proxyconfigurations | |||
| - gatewayclassconfigs | |||
There was a problem hiding this comment.
Can we move this up to be in alphabetical order?
sarahalsmiller
force-pushed
the
NET-6535-stub-k8s-controller
branch
from
5a07d25
to
f0f0ed2
Compare
missylbytes
reviewed
Nov 28, 2023
| @@ -183,7 +183,17 @@ func (c *Command) configureV2Controllers(ctx context.Context, mgr manager.Manage | |||
| Log: ctrl.Log.WithName("controller").WithName(common.MeshGateway), | |||
| Scheme: mgr.GetScheme(), | |||
| }).SetupWithManager(mgr); err != nil { | |||
| setupLog.Error(err, "unable to create controller", "controller", common.MeshGateway) | |||
| setupLog.Error(err, "unable to create controller", "controller", common.GatewayClassConfig) | |||
There was a problem hiding this comment.
Accidental find replace
missylbytes
requested changes
Nov 28, 2023
missylbytes
approved these changes
Nov 28, 2023
jm96441n
pushed a commit
that referenced
this pull request
Nov 29, 2023
* rename v1 crd * gatewayclass controller stub * register controller * old version * reorder cluster role * fix accidental find and replace error
sarahalsmiller
added a commit
that referenced
this pull request
Jan 5, 2024
* rename v1 crd * gatewayclass controller stub * register controller * old version * reorder cluster role * fix accidental find and replace error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: