ProxyDefaults CRD #328
Merged
ProxyDefaults CRD #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also make controller and webhook code generic * Update to controller-runtime 0.6.3 to fix spurious log error message.
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
4102336
to
84b316f
Compare
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
84b316f
to
baba87b
Compare
lkysow
force-pushed
the
crd-controller-resolver
branch
from
245b858
to
d62b005
Compare
Base automatically changed from
crd-controller-resolver
to
crd-controller-base
September 22, 2020 22:05
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
6ecbedf
to
de43cb5
Compare
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
617344e
to
f19ceb9
Compare
thisisnotashwin
requested review from
lkysow,
a team and
kschoche
and removed request for
a team
|
Also this branch says it has 15 commits so you may need to futz with the git history. |
lkysow
requested changes
Sep 24, 2020
I think the merge takes care of that |
- Review comments
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
8b6943c
to
a31ae31
Compare
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
a31ae31
to
2469414
Compare
|
gonna squash and merge this pupper |
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
2469414
to
635a221
Compare
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
635a221
to
9ef644e
Compare
lkysow
reviewed
Sep 24, 2020
thisisnotashwin
force-pushed
the
crd-controller-proxy-def
branch
from
4f99a65
to
e261416
Compare
lkysow
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Implement support for
proxy-defaultsconfig entries:Copy its type definition over from Consul and implement
toConsul()andmatchesConsul()Create controller and webhook for it
Run generators to create deepcopy and yaml files
How I've tested this PR: Acceptance tests from hashicorp/consul-helm#614
How I expect reviewers to test this PR:
Reviewing the acceptance tests from hashicorp/consul-helm#614 should show that the refactoring didn't break anything
I've built ashwinvenkatesh/consul-k8s@sha256:41b9c7f6a38e1b9f8d8c444f65607d7387ebbf09c43def8911eb2c5a93f1f160 that can be tested with.
Additionally, the
webhook-cert-managerthat gets spun up here should have less noisy log lines.• not gonna lie, i felt lazy, so i copied over @lkysow description from ServiceResolver and removed the cool bit about a refactor. thanks Luke!!