Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate CR namespaces based on consul namespaces #375

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Validate CR namespaces based on consul namespaces #375

merged 2 commits into from
Nov 4, 2020

Commits on Nov 4, 2020

  1. Validate CR namespaces based on consul namespaces 

    ServiceRouters, ServiceResolvers, ServiceSplitters, and
ServiceIntentions should only have namespaces set in their spec when
consul namespaces are enabled. When consul namespaces are disabled, the
webhook now returns a validation error if these CRs have a namespace.

Previously, users could apply CRs with namespaces set even when consul
namespaces are disabled, causing them to think the namespaces might be
having an effect when they are not.

Co-authored-by: Ashwin Venkatesh <[email protected]>
    @ndhanushkodi @thisisnotashwin
    ndhanushkodi and thisisnotashwin committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    06b3757 View commit details
    Browse the repository at this point in the history

  2. Update error message to Consul Enterprise namespaces 

    This would make it easier for a user to understand that they need Consul
Enterprise in order to enable namespaces.
    @ndhanushkodi
    ndhanushkodi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    00bc0f1 View commit details
    Browse the repository at this point in the history