Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of activate tproxy mode even when a cluster IP is not assigned to pod into release/1.4.x #3977

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #3974 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@dhiaayachi
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "6bd405f4e16a7a00ad9bf1de7e12d82ebdbaa6bd", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Changes proposed in this PR

Consul service should be create with mode transparent proxy even when a cluster IP is not assigned to the service.

How I've tested this PR

Manually tested using an EKS cluster

How I expect reviewers to test this PR

NA


Overview of commits

@dhiaayachi dhiaayachi merged commit ecb412d into release/1.4.x May 9, 2024
48 of 49 checks passed
@dhiaayachi dhiaayachi deleted the backport/tproxy-headless-service/deeply-massive-weasel branch May 9, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants