Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Net 4414 remove anyuid openshift requirement into release/1.4.x #4160

Conversation

hc-github-team-consul-core
Copy link

@hc-github-team-consul-core hc-github-team-consul-core commented Jul 9, 2024

Backport

This PR is auto-generated from #4152 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR

This PR solves two problems:

  • Adds the NET_BIND_SERVICE capability to the Consul Dataplane containers that are created. This work was done in another PR, but has been pulled into this one. Original PR
  • Removes the need on Openshift for using an SCC that allows anyuid. We now use the annotation provided by Openshift on the namespace to set the user and group IDs for our containers. This work was originally done in another PR, but has been pulled into this one and expanded to cover API gateways and use separate user/group IDs for the init + dataplane containers that do not conflict with application user/group IDs. Original PR

How I've tested this PR

Manual testing
Unit tests

How I expect reviewers to test this PR

Follow this gist to setup and install Consul onto Openshift

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/net-4414-remove-anyuid-openshift-requirement/extremely-top-osprey branch from c38693f to 50c904d Compare July 9, 2024 20:22
Co-authored-by: Curt Bushko <[email protected]>
Co-authored-by: Nathan Coleman <[email protected]>
@nathancoleman nathancoleman force-pushed the backport/net-4414-remove-anyuid-openshift-requirement/extremely-top-osprey branch from 50c904d to daf22d4 Compare July 9, 2024 20:34
@nathancoleman nathancoleman marked this pull request as ready for review July 9, 2024 20:34
@sarahalsmiller sarahalsmiller force-pushed the backport/net-4414-remove-anyuid-openshift-requirement/extremely-top-osprey branch from d46c23b to 6299fb7 Compare July 9, 2024 21:33
@sarahalsmiller sarahalsmiller enabled auto-merge (squash) July 9, 2024 21:38
@sarahalsmiller sarahalsmiller merged commit a09a6fd into release/1.4.x Jul 10, 2024
52 checks passed
@sarahalsmiller sarahalsmiller deleted the backport/net-4414-remove-anyuid-openshift-requirement/extremely-top-osprey branch July 10, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants