Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-5272/add docs team code owners to review helm values description #4237

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

JadhavPoonam
Copy link
Contributor

@JadhavPoonam JadhavPoonam commented Aug 7, 2024

Changes proposed in this PR

  • Adds a CODEOWNERS file that would request a review from the docs team when helm values are changed. This review is non-blocking as we don't set the required review setting in the branch protection rules.

How I've tested this PR

It should take effect in the next PR.

### How I expect reviewers to test this PR ###

Checklist

@JadhavPoonam JadhavPoonam force-pushed the NET-5272/add-docs-team-for-code-review branch from 43fffc7 to 5a38959 Compare August 7, 2024 16:53
@JadhavPoonam JadhavPoonam marked this pull request as ready for review August 8, 2024 14:52
@JadhavPoonam JadhavPoonam marked this pull request as draft August 8, 2024 14:52
@JadhavPoonam JadhavPoonam force-pushed the NET-5272/add-docs-team-for-code-review branch from 5a38959 to 014d792 Compare August 8, 2024 15:02
@JadhavPoonam JadhavPoonam force-pushed the NET-5272/add-docs-team-for-code-review branch from 014d792 to f86f00e Compare August 8, 2024 15:04
@JadhavPoonam JadhavPoonam added the pr/no-changelog PR does not need a corresponding .changelog entry label Aug 8, 2024
@JadhavPoonam JadhavPoonam changed the title wip NET-5272 Aug 8, 2024
@JadhavPoonam
Copy link
Contributor Author

Please double-check the backport labels for me as I am not sure which versions of K8s we are backporting to now.

@JadhavPoonam JadhavPoonam marked this pull request as ready for review August 8, 2024 17:14
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the note on branch protections! LGTM.

Minor nit, can we add a description to the PR title as well so it's clear from preview links and the squashed merge commit what the change was?

@zalimeni
Copy link
Member

zalimeni commented Aug 14, 2024

Please double-check the backport labels for me as I am not sure which versions of K8s we are backporting to now.

You nailed it! There's also a doc here w/ more info about the backport policy: https://go.hashi.co/consul-backports

We also update labels on each major release to gray out and describe old labels as no longer active (and eventually remove them when we're well past the last patch release for that version).

@JadhavPoonam JadhavPoonam changed the title NET-5272 NET-5272/add docs team code owners to review helm values description Aug 14, 2024
@JadhavPoonam JadhavPoonam enabled auto-merge (squash) August 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.1.x Backport to release/1.1.x branch backport/1.3.x backport/1.4.x backport/1.5.x pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants