NET-10891: Add authorization middleware to sync catalog metrics endpoint #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return func(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| // TO-DO: Validate the token and proceed to the next handler | ||
| token := r.Header.Get("X-Consul-Token") | ||
| c.validateToken(token, consulConfig) |
There was a problem hiding this comment.
assuming this would be something like
if !c.validateToken(token, consulConfig) {
http.Error(w, 500, "invalid token")
return
}
next.ServeHTTP(w, r)
NiniOak
added
pr/no-changelog
NiniOak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
validateTokenstep to ensure X-Consul-Token used to make API requests to the new catalog sync metrics endpoint(/metrics) is validHow I've tested this PR
TBD
How I expect reviewers to test this PR
TBD
Checklist