Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-10961] Ignore gke managed namespaces by default #4333

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

jm96441n
Copy link
Member

Changes proposed in this PR

  • on GKE we should not attempt to inject pods in a gke managed namespaces because many of them do not have a corresponding k8s service which causes the connect injector container to crash and send those pods into an infinite crash loop

How I've tested this PR

  • deployed gke cluster with consul using this helm chart update, the containers in the gke managed namespaces were no longer crashing after this change

How I expect reviewers to test this PR

Follow the instructions in the README for this repo: https://github.com/jm96441n/consul-experiments/tree/main/k8s/gke-ns

Checklist

@jm96441n jm96441n requested a review from a team September 17, 2024 19:51
@jm96441n jm96441n requested a review from a team as a code owner September 17, 2024 19:51
@jm96441n jm96441n requested review from missylbytes and wangxinyi7 and removed request for a team September 17, 2024 19:51
@NiniOak NiniOak merged commit 6beaeb0 into main Sep 19, 2024
49 checks passed
@NiniOak NiniOak deleted the NET-10961-exclude-gke-namespaces-from-connect-inject branch September 19, 2024 19:32
sarahalsmiller pushed a commit that referenced this pull request Sep 20, 2024
* ignore gke managed namespaces by default

* Add changelog

* remove spaces
sarahalsmiller added a commit that referenced this pull request Sep 20, 2024
* remove version from skip check (#4338)

* [NET-10961] Ignore gke managed namespaces by default (#4333)

* ignore gke managed namespaces by default

* Add changelog

* remove spaces

* add exception to pr.yaml (#4346)

* [NET-11106] Make bats testing more reproducible (#4345)

* testing out changes to bats testing

* use pre-built image

* update ref for bats testing

* remove extra newline

* remove extra newline

* prepare release

---------

Co-authored-by: John Maguire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants