Fix incorrect validation for ServiceResolver #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
service-resolver-bugfix
branch
from
e6f6ee7
to
f0626bf
Compare
lkysow
commented
Mar 15, 2021
| asJSON, _ := json.Marshal(in) | ||
| errs = append(errs, field.Invalid(path, string(asJSON), | ||
| "cannot set both field and sourceIP")) | ||
| } else if in.FieldValue == "" { |
There was a problem hiding this comment.
using else if here because if they're setting:
field: cookie
sourceIP: true
then thought only one error (can't set both field and sourceIP) is clearer than two: (can't set both field and sourceIP, if field is set fieldValue must also be set)
lkysow
requested review from
a team,
ndhanushkodi and
thisisnotashwin
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
ServiceResolvervalidation: if hashPolicy.field is set fieldValue must also be setServiceResolvervalidation: hashPolicy.field can be empty if hashPolicy.sourceIP is trueHow I've tested this PR:
How I expect reviewers to test this PR:
Checklist: