Add startup probe to connect inject deployment. #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did so in hashicorp/consul-helm#885, but it never got released. This adds the same probe now that we have a health endpoint in the webhook. This also changes the periodSeconds for the liveness and readiness probes to use the default of 10s instead of 2s we used previously. That is because now with the startup probe in place, we don't need to check for certs being present that frequently.
lkysow
approved these changes
Aug 31, 2021
thisisnotashwin
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did so in hashicorp/consul-helm#885, but it never got released.
This adds the same probe now that we have a health endpoint in the webhook.
This also changes the periodSeconds for the liveness and readiness probes
to use the default of 10s instead of 2s we used previously.
That is because now with the startup probe in place,
we don't need to check for certs being present that frequently.
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: