Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate the statefulset pvc name to be max 63 chars #799

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Truncate the statefulset pvc name to be max 63 chars #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
129c528
Truncate the statefulset pvc name to be max 63 chars
Oct 20, 2021
f762577
Add unit tests for pvc name truncation
Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/consul/templates/server-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ spec:
-config-file=/consul/extra-config/extra-from-values.json \
-server
volumeMounts:
- name: data-{{ .Release.Namespace }}
- name: data-{{ .Release.Namespace | trunc 58 | trimSuffix "-" }}
mountPath: /consul/data
- name: config
mountPath: /consul/config
Expand Down Expand Up @@ -365,7 +365,7 @@ spec:
{{- end }}
volumeClaimTemplates:
- metadata:
name: data-{{ .Release.Namespace }}
name: data-{{ .Release.Namespace | trunc 58 | trimSuffix "-" }}
spec:
accessModes:
- ReadWriteOnce
Expand Down
22 changes: 22 additions & 0 deletions charts/consul/test/unit/server-statefulset.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,28 @@ load _helpers
[ "${actual}" = "2" ]
}

#--------------------------------------------------------------------
# volumeClaim name

@test "server/StatefulSet: no truncation for namespace <= 58 chars" {
cd `chart_dir`
local actual=$(helm template \
-s templates/server-statefulset.yaml \
. | tee /dev/stderr |
yq -r '.spec.volumeClaimTemplates[0].metadata.name' | tee /dev/stderr)
[ "${actual}" = "data-default" ]
}

@test "server/StatefulSet: truncation for namespace > 58 chars" {
cd `chart_dir`
local actual=$(helm template \
-n really-really-really-really-really-really-really-long-namespace \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

-s templates/server-statefulset.yaml \
. | tee /dev/stderr |
yq -r '.spec.volumeClaimTemplates[0].metadata.name' | tee /dev/stderr)
[ "${actual}" = "data-really-really-really-really-really-really-really-long-name" ]
}

#--------------------------------------------------------------------
# storageClass

Expand Down