Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingressClassName for UI #909

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Add ingressClassName for UI #909

merged 4 commits into from
Dec 8, 2021

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Dec 7, 2021

Work based on existing PR: #780

Closes #897

Changes proposed in this PR:

  • Add support for ingressClassName
  • Test ingress UI with different Kube versions

How I've tested this PR:

Bats!

How I expect reviewers to test this PR:

Bats!

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@t-eckert t-eckert requested review from a team, ndhanushkodi and kschoche and removed request for a team December 7, 2021 20:35
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!!

@t-eckert t-eckert merged commit e1badb2 into main Dec 8, 2021
@t-eckert t-eckert deleted the ingress-class-name branch December 8, 2021 17:59
rrondeau pushed a commit to rrondeau/consul-k8s that referenced this pull request Dec 21, 2021
* update changelog for tproxy connect refactor

Co-authored-by: Iryna Shustava <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying ingressClassName for UI ingress
4 participants