Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save exposed ports in agent's store and expose them via API #10173

Merged
merged 6 commits into from
May 12, 2021

Conversation

ishustava
Copy link
Contributor

@ishustava ishustava commented May 4, 2021

See @freddygv 's comment for more info about why we need this change.

This PR changes the following:

  • Saves exposed HTTP and GRPC ports to the agent's store
  • Adds those the health checks API so we can retrieve them from the API
  • Changes redirect-traffic command to also exclude those ports from inbound traffic redirection when expose.checks is set to true.

Notes:

TODO:

  • Add changelog

@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label May 4, 2021
@mikemorris mikemorris added this to the 1.10.0 milestone May 4, 2021
@vercel vercel bot temporarily deployed to Preview – consul May 6, 2021 05:06 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 6, 2021 05:06 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 6, 2021 17:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 6, 2021 17:28 Inactive
@ishustava ishustava requested a review from a team May 6, 2021 18:05
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, the plumbing all looks good to me.

I added a couple minor comments/questions.

agent/agent.go Outdated Show resolved Hide resolved
agent/agent.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 10, 2021 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 10, 2021 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 10, 2021 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 10, 2021 16:15 Inactive
@ishustava ishustava requested a review from freddygv May 10, 2021 16:19
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 10, 2021 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 10, 2021 17:02 Inactive
agent/agent_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 10, 2021 19:51 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 10, 2021 19:51 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 10, 2021 20:08 Inactive
@ishustava ishustava requested a review from freddygv May 10, 2021 22:20
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ishustava ishustava merged commit d7d44f6 into master May 12, 2021
@ishustava ishustava deleted the expose-exposed-ports branch May 12, 2021 20:51
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/368156.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit d7d44f6 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request May 12, 2021
* Save exposed HTTP or GRPC ports to the agent's store
* Add those the health checks API so we can retrieve them from the API
* Change redirect-traffic command to also exclude those ports from inbound traffic redirection when expose.checks is set to true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/api Relating to the HTTP API interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants