-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save exposed ports in agent's store and expose them via API #10173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, the plumbing all looks good to me.
I added a couple minor comments/questions.
73e388a
to
b31aea2
Compare
dadad44
to
af90ac7
Compare
af90ac7
to
8efcfeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/368156. |
🍒✅ Cherry pick of commit d7d44f6 onto |
* Save exposed HTTP or GRPC ports to the agent's store * Add those the health checks API so we can retrieve them from the API * Change redirect-traffic command to also exclude those ports from inbound traffic redirection when expose.checks is set to true.
See @freddygv 's comment for more info about why we need this change.
This PR changes the following:
redirect-traffic
command to also exclude those ports from inbound traffic redirection when expose.checks is set to true.Notes:
mog
from WIP: mog: code gen tool for converting api types into core types #8604 to generate the structsTODO: