Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LastErrorMessage to /acl/replication docs #11990

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add LastErrorMessage to /acl/replication docs #11990

merged 1 commit into from
Jan 10, 2022

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Jan 10, 2022 •
edited
Loading

#10612 added a LastErrorMessage field to the API response payload for the /acl/replication endpoint. Add this field to the API documentation.

@kisunji kisunji requested a review from a team as a code owner January 10, 2022 18:36
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jan 10, 2022
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@kisunji kisunji added event/consul-docs-day A day focused on improving Consul's documentation. Date: Jan 10, 2022. type/docs-cherrypick pr/no-changelog PR does not need a corresponding .changelog entry labels Jan 10, 2022
blake
blake approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@blake blake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kisunji kisunji merged commit 65f97e6 into main Jan 10, 2022
@kisunji kisunji deleted the kisunji/acl-replication-doc branch January 10, 2022 18:42
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/544443.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 65f97e6 onto stable-website succeeded!

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 65f97e6 onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 10, 2022
@hc-github-team-consul-core
Add LastErrorMessage to /acl/replication docs (#11990)
afe351c
hc-github-team-consul-core pushed a commit that referenced this pull request Jan 10, 2022
@hc-github-team-consul-core
Add LastErrorMessage to /acl/replication docs (#11990)
522b402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blake blake blake approved these changes

Assignees
No one assigned
Labels
event/consul-docs-day A day focused on improving Consul's documentation. Date: Jan 10, 2022. pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kisunji @hashicorp-ci @hc-github-team-consul-core @blake