Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy register port race 2 test #14197

Closed
wants to merge 2 commits into from
Closed

Conversation

skpratt
Copy link
Contributor

@skpratt skpratt commented Aug 12, 2022

Description

Describe why you're making this change, in plain English.

Testing & Reproduction steps

  • In the case of bugs, describe how to replicate
  • If any manual tests were done, document the steps and the conditions to replicate
  • Call out any important/ relevant unit tests, e2e tests or integration tests you have added or are adding

Links

Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.

Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@@ -1,7 +1,7 @@
# Note this arg has to be before the first FROM
ARG ENVOY_VERSION

FROM consul-dev as consul
FROM --platform=linux/amd64 consul-dev as consul
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the default version of envoy is 1.23.0, but that version of the arm container is broken. I wonder if you used 1.22.4 if you'd need this change.

@skpratt skpratt closed this Aug 17, 2022
@skpratt skpratt deleted the proxy-register-port-race-2-test branch August 26, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants