Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [OSS] gRPC Blocking Queries into release/1.15.x #17441

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17426 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@DanStough
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

This PR adds blocking support to gRPC endpoints used for peering. Currently, these poll at a constant 1s interval. This is too slow for mesh gateway updates when using PeerThroughMeshGateways and too fast for steady-state updates that may trigger disco-chain compilation.

Testing & Reproduction steps

  • CI automated test
  • You can manually curl the HTTP endpoints using blocking query semantics and observe updates only on change.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/dans/NET-1948/blocking-queries-attempt-3/noticeably-immune-mite branch 2 times, most recently from 946c1d2 to 5526290 Compare May 23, 2023 21:29
@hashicorp-cla
Copy link

hashicorp-cla commented May 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 23, 2023 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 23, 2023 21:36 Inactive
@DanStough DanStough force-pushed the backport/dans/NET-1948/blocking-queries-attempt-3/noticeably-immune-mite branch from 216728e to 5aa4cf9 Compare May 24, 2023 15:03
@DanStough DanStough marked this pull request as ready for review May 24, 2023 15:03
@DanStough DanStough requested a review from a team as a code owner May 24, 2023 15:03
Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straight cherry-pick of commits already reviewed in ENT.

@DanStough DanStough merged commit a596041 into release/1.15.x May 24, 2023
@DanStough DanStough deleted the backport/dans/NET-1948/blocking-queries-attempt-3/noticeably-immune-mite branch May 24, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants