Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Property Override validation improvements into release/1.16.x #17778

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Backport of Property Override validation improvements into release/1.16.x #17778

merged 2 commits into from
Jun 15, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17759 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.

Description

Improve validation by property-override builtin Envoy Extension.

  • Reject invalid ResourceFilter combination of TrafficDirection: inbound w/ non-empty Services
  • Cover additional invalid field cases due to type mismatch or unsupported target
  • Add specific error message for attempting to set Any fields

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/net-4245-net-3935-prop-override-validation-improvements/rarely-wondrous-tahr branch from 88f8221 to b6b0624 Compare June 15, 2023 17:52
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/net-4245-net-3935-prop-override-validation-improvements/rarely-wondrous-tahr branch 2 times, most recently from 479cfcd to 2a38af8 Compare June 15, 2023 17:52
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 9dab351 into release/1.16.x Jun 15, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/zalimeni/net-4245-net-3935-prop-override-validation-improvements/rarely-wondrous-tahr branch June 15, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@zalimeni zalimeni Awaiting requested review from zalimeni

Assignees

@zalimeni zalimeni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @zalimeni