Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-4703] Prevent partial application of Envoy extensions #18068

Merged

Commits on Jul 27, 2023

  1. Prevent partial application of Envoy extensions

    Ensure that non-required extensions do not change xDS resources before
    exiting on failure by cloning proto messages prior to applying each
    extension.
    
    To support this change, also move `CanApply` checks up a layer and make
    them prior to attempting extension application, s.t. we avoid
    unnecessary copies where extensions can't be applied.
    
    Last, ensure that we do not allow panics from `CanApply` or `Extend`
    checks to escape the attempted extension application.
    zalimeni committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    a920c71 View commit details
    Browse the repository at this point in the history