Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Add license-checker action that fails when any backported file contains BUSL header into release/1.14.x #18488

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Backport of Add license-checker action that fails when any backported file contains BUSL header into release/1.14.x #18488

merged 1 commit into from
Aug 16, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Aug 16, 2023 •
edited by nathancoleman
Loading

Backport

This PR is auto-generated from #18485 to be assessed for backporting due to the inclusion of the label backport/1.14.

The below text is copied from the body of the original PR.

Description

We want to make sure that we aren't accidentally backporting the BUSL license header into versions of Consul that should remain under MPL through the end of the year.

Testing & Reproduction steps

Run script locally on main where it should fail, identifying files which have the BUSL header, and on release branches such as release/1.16.x where it should succeed since no files have the BUSL header.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/license-checker/externally-moral-lynx branch from 0bdbf36 to 454e43e Compare August 16, 2023 18:35
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/license-checker/externally-moral-lynx branch 2 times, most recently from f897cae to 454e43e Compare August 16, 2023 18:35
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 16, 2023 18:35 Inactive
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/api Relating to the HTTP API interface theme/health-checks Health Check functionality theme/acls ACL and token generation theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/ui Anything related to the UI theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication theme/telemetry Anything related to telemetry or observability type/ci Relating to continuous integration (CI) tooling for testing or releases pr/dependencies PR specifically updates dependencies of project theme/envoy/xds Related to Envoy support theme/contributing Additions and enhancements to community contributing materials theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/agent-cache Agent Cache theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation labels Aug 16, 2023
@hc-github-team-consul-core
Copy link
Collaborator Author

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul August 16, 2023 18:40 Inactive
@nathancoleman
Add license-checker action that fails when any backported file contai…
b9e098e 
…ns BUSL header (#18485)

* Add license-checker action that fails when any backported file contains BUSL header

* Quote echoed variable to retain line breaks

* Add ticket to reference for more details
@nathancoleman nathancoleman force-pushed the backport/license-checker/externally-moral-lynx branch from 454e43e to b9e098e Compare August 16, 2023 18:43
nathancoleman
nathancoleman approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches source PR

@nathancoleman nathancoleman marked this pull request as ready for review August 16, 2023 19:33
@nathancoleman nathancoleman merged commit ed7ab42 into release/1.14.x Aug 16, 2023
84 checks passed
@nathancoleman nathancoleman deleted the backport/license-checker/externally-moral-lynx branch August 16, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@nathancoleman nathancoleman nathancoleman approved these changes

Assignees

@nathancoleman nathancoleman

Labels
pr/dependencies PR specifically updates dependencies of project theme/acls ACL and token generation theme/agent-cache Agent Cache theme/api Relating to the HTTP API interface theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation theme/contributing Additions and enhancements to community contributing materials theme/envoy/xds Related to Envoy support theme/health-checks Health Check functionality theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics theme/telemetry Anything related to telemetry or observability theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication theme/ui Anything related to the UI type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @nathancoleman @github-team-consul-core-pr-approver